Use google translate #189
Merged
Use google translate #189
+474
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g especially if it merges an updated upstream into a topic branch.
Deploying nepalingo with
|
| Latest commit: |
5f44292
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53208a13.nepalingo.pages.dev |
| Branch Preview URL: | https://use-google-translate.nepalingo.pages.dev |
binamkayastha
approved these changes
Aug 8, 2024
nepalingo-web/package.json
Outdated
| "lottie-react": "^2.4.0", | ||
| "node-fetch": "^3.3.2", |
There was a problem hiding this comment.
I don't think we need these packages?
There was a problem hiding this comment.
Can we remove them and re-generate the pnpm lock file?
| if (newariResult.meanings.length === 0) { | ||
| console.log("Used Google Translate for newari"); | ||
| return await getGTranslate("newari", word); | ||
| } |
There was a problem hiding this comment.
Nice and simple! This is some nice DRY code!
| case "Tajpuriya": | ||
| return await getTajpuriyaWord(word); | ||
| case "Maithili": | ||
| return await getGTranslate("maithili", word); |
| }> => { | ||
| const targetLanguage = languageCodes[language]; | ||
| if (!targetLanguage) { | ||
| throw new Error(`Language code for ${language} not found`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Language code for ${language} not found`); | |
| throw new Error(`Google translate language code for ${language} not found`); |
There was a problem hiding this comment.
This change will make it more clear why the error is occurring and hints at what file to look at.
| @@ -0,0 +1,45 @@ | |||
| const GOOGLE_TRANSLATE_API_KEY = "AIzaSyCi239eredIAEEJkI8xzvGwW1GPS7B1vxQ"; | |||
There was a problem hiding this comment.
Can we move this into the .env file
|
Nice thanks for testing and catching that env var error before merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a getGTranslate lib
Udated the useDictionary to use getGTranslate for maithili and for newari backup.
challenges:
Error: Requests from referer http://localhost:5173/ are blocked.
can't test it because of this error.
Tried setting up a proxy server (have created a file called proxy.js) but am not sure about it and don't know how to use it.